On Mon, Jun 20, 2022 at 12:54 PM Chen-Yu Tsai <wenst@xxxxxxxxxxxx> wrote: > > On Sat, Jun 18, 2022 at 3:29 PM Yunfei Dong <yunfei.dong@xxxxxxxxxxxx> wrote: > > > > Need to get dec_capability from scp first, then initialize decoder > > supported format and other parameters according to dec_capability value. > > > > Signed-off-by: Yunfei Dong <yunfei.dong@xxxxxxxxxxxx> > > Reviewed-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx> > Tested-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx> > > Tested on MT8183 on mainline 20220617-next with the vcodec-dec DT node > copied from the ChromeOS v5.10 kernel. > > This fixes an issue where the first attempt to enumerate formats on the > device right after boot returns an empty list. BTW, this should have a Fixes tag. Either Fixes: 7a7ae26fd458 ("media: mediatek: vcodec: support stateless VP8 decoding") which looks like the first instance of when firmware capability really is considered, or Fixes: fd00d90330d1 ("media: mtk-vcodec: vdec: move stateful ops into their own file") which matches when ctx->dev->vdec_pdata->init_vdec_params(ctx) was first added. ChenYu