Hi, > -----Original Message----- > From: Baolu Lu <baolu.lu@xxxxxxxxxxxxxxx> > Sent: Wednesday, May 25, 2022 3:27 PM > To: iwamatsu nobuhiro(岩松 信洋 □SWC◯ACT) > <nobuhiro1.iwamatsu@xxxxxxxxxxxxx>; Joerg Roedel <joro@xxxxxxxxxx>; Will > Deacon <will@xxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Jason > Gunthorpe <jgg@xxxxxxxxxx> > Cc: baolu.lu@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx; ishikawa > yuji(石川 悠司 ○RDC□AITC○EA開) > <yuji2.ishikawa@xxxxxxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/3] iommu: Add Visconti5 IOMMU driver > > On 2022/5/25 09:31, Nobuhiro Iwamatsu wrote: > > +static const struct iommu_ops visconti_atu_ops = { > > + .domain_alloc = visconti_atu_domain_alloc, > > + .probe_device = visconti_atu_probe_device, > > + .release_device = visconti_atu_release_device, > > + .device_group = generic_device_group, > > + .of_xlate = visconti_atu_of_xlate, > > + .pgsize_bitmap = ATU_IOMMU_PGSIZE_BITMAP, > > + .default_domain_ops = &(const struct iommu_domain_ops) { > > + .attach_dev = visconti_atu_attach_device, > > + .detach_dev = visconti_atu_detach_device, > > The detach_dev callback is about to be deprecated. The new drivers should > implement the default domain and blocking domain instead. I see. I will update this with next version. > > > + .map = visconti_atu_map, > > + .unmap = visconti_atu_unmap, > > + .iova_to_phys = visconti_atu_iova_to_phys, > > + .free = visconti_atu_domain_free, > > + } > > +}; > > Best regards, > baolu Best regards, Nobuhiro