Hi Francesco, > Subject: Re: [RESEND PATCH v2 0/9] imx: thermal: Allow trip point > configuration from DT > > Hello Jacky, > > On Fri, Jun 17, 2022 at 07:31:25AM +0000, Jacky Bai wrote: > > > Subject: [RESEND PATCH v2 0/9] imx: thermal: Allow trip point > > > configuration from DT > > > > > > This series allows to specify the imx thermal drivers trip point > > > from the device tree, without this change the threshold are > > > hard-coded and this might not be correct given the thermal design of the > final system. > > > > > > > The threshold is set dynamically based on the part market temp grade. > > I am little confused why need to specify it in DT? I saw in 'PATCH > > 5/9', you provide a threshold table based temp grade, why not use the > > threshold from ' imx_init_temp_grade'? > > The problem with the existing temperature thresholds is that they are > hard-coded into the driver, there is no way to change those to match the > actual final system thermal design. > > After various discussions [1][2] with Marco, Daniel and Lucas it was agreed > that the actual trip is indeed a system property and therefore should be > described in the device tree. This series make it possible in a backward > compatible way, this new possibility is than used to override the threshold in > some system-specific dts (see patches 6,7,8 and 9). > Thx. Yes, in current driver design, the critical trip is fixed at 5 Celsius lower than the MAX limited. So the purpose of this patch is just want to override this limitation to adjust it based on system need? BR Jacky Bai > Francesco >
