> Subject: [RESEND PATCH v2 0/9] imx: thermal: Allow trip point configuration > from DT > > This series allows to specify the imx thermal drivers trip point from the device > tree, without this change the threshold are hard-coded and this might not be > correct given the thermal design of the final system. > The threshold is set dynamically based on the part market temp grade. I am little confused why need to specify it in DT? I saw in 'PATCH 5/9', you provide a threshold table based temp grade, why not use the threshold from ' imx_init_temp_grade'? BR Jacky Bai > This change is backward compatible with the existing device tree, and even > with this change in by default the thresholds are the same as before. > > Toradex board are also updated to use a system-specific thresholds. > > Discussion on the current design is here: > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.ke > rnel.org%2Fall%2F4ba1d7d2-3e8c-ba60-37fd-9598f415c076%40linaro.org%2 > F&data=05%7C01%7Cping.bai%40nxp.com%7C3bd9173c93184270acee > 08da5030fdfb%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6379 > 10468593014918%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAi > LCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C& > amp;sdata=L0T4514vcK0Nl1Vv9EVNdhDJMpBGqIRP68GFKVeBvwg%3D& > ;reserved=0 > > One side note, after this change the dtbs checker starts complaining with this > message > > ``` > linux/arch/arm/boot/dts/imx6dl-alti6p.dtb: tempmon: > '#thermal-sensor-cells' does not match any of the regexes: > '^(automotive|commercial|extended-commercial|industrial)-thermal$', > 'pinctrl-[0-9]+' > From schema: > linux/Documentation/devicetree/bindings/thermal/imx-thermal.yaml > ``` > > to my understanding this is just a side effect, '#thermal-sensor-cells' is not > changed in any way by this series. I can fix that, I wonder if I should remove > the property from the imx dtsi files or add it to the binding yaml definition, not > sure about it. > Anybody can advise? > > Changes in v2: > - fix build error without CONFIG_THERMAL_OF > - more verbose error reporting in case the dts is not correct > - additional comment on the threshold fixup in case the passive threshold is > higher than critical > - while parsing the dts thermal, return immediately if the node is not there > > > Francesco Dolcini (9): > dt-bindings: thermal: Define trips node in $defs > thermal: thermal: Export OF trip helper function > dt-bindings: thermal: imx: Add trips point > imx: thermal: Configure trip point from DT > ARM: dts: imx[67]: Add trips points > ARM: dts: imx6qdl-apalis: Set CPU critical trip point > ARM: dts: imx7-colibri: Set CPU critical trip point > ARM: dts: imx6ull-colibri: Set CPU critical trip point > ARM: dts: imx6qdl-colibri: Set CPU critical trip point > > .../bindings/thermal/imx-thermal.yaml | 27 ++++ > .../bindings/thermal/thermal-zones.yaml | 130 +++++++++--------- > arch/arm/boot/dts/imx-thermal.dtsi | 61 ++++++++ > arch/arm/boot/dts/imx6qdl-apalis.dtsi | 12 ++ > arch/arm/boot/dts/imx6qdl-colibri.dtsi | 12 ++ > arch/arm/boot/dts/imx6qdl.dtsi | 2 + > arch/arm/boot/dts/imx6sl.dtsi | 2 + > arch/arm/boot/dts/imx6sll.dtsi | 2 + > arch/arm/boot/dts/imx6sx.dtsi | 2 + > arch/arm/boot/dts/imx6ul.dtsi | 2 + > arch/arm/boot/dts/imx6ull-colibri.dtsi | 12 ++ > arch/arm/boot/dts/imx7-colibri.dtsi | 12 ++ > arch/arm/boot/dts/imx7s.dtsi | 2 + > drivers/thermal/imx_thermal.c | 58 ++++++++ > drivers/thermal/thermal_core.h | 7 + > drivers/thermal/thermal_of.c | 5 +- > 16 files changed, 283 insertions(+), 65 deletions(-) create mode 100644 > arch/arm/boot/dts/imx-thermal.dtsi > > -- > 2.25.1
