Hi Krzysztof, On Thu, 16 Jun 2022 at 16:39, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 16/06/2022 06:24, Tomer Maimon wrote: > > Hi Krzysztof, > > > > On Wed, 15 Jun 2022 at 20:03, Krzysztof Kozlowski > > <krzysztof.kozlowski@xxxxxxxxxx> wrote: > >> > >> On 13/06/2022 02:25, Tomer Maimon wrote: > >>> Hi Krzysztof, > >>> > >>> Thanks for your clarification. > >>> > >>> We can remove the dt-binding file and use numbers in the DTS, > >>> appreciate if you can answer few additional questions: > >>> 1. Do you suggest adding all NPCM reset values to the NPCM reset > >>> document or the reset values should describe in the module > >>> documentation that uses it? > >> > >> What is "NPCM reset document"? Are these reset values anyhow different > >> than interrupts or pins? > > No, they represent the same values. > > > We do not document in the bindings actual pin or interrupt numbers... > > >> > >>> 2. Some of the NPCM7XX document modules describe the reset value they > >>> use from the dt-binding for example: > >>> https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/iio/adc/nuvoton%2Cnpcm750-adc.yaml#L61 > >> > >> This is NPCM750 > >> > >>> If we remove the NPCM8XX dt-binding file should we describe the > >>> NPCM8XX values in the NPCM-ADC document file? > >> > >> What is NPCM-ADC document file? What do you want to describe there? > >> Again - how is it different than interrupts? > > It is not different from the interrupts. > > I will remove the dt-binding reset include file, the reset property > > will use numbers and not macro's. > > I have no clue what are you referring now... This is NPCM8xx and it has > no binding header with reset values. What to remove then? I refer nuvoton,npcm8xx-reset.h file, we don't need it. > > > Best regards, > Krzysztof
