Am 15. Juni 2022 15:44:04 OEZ schrieb Linus Walleij <linus.walleij@xxxxxxxxxx>: >On Fri, Jun 3, 2022 at 3:56 PM Aidan MacDonald ><aidanmacdonald.0x0@xxxxxxxxx> wrote: > >> The AXP192 PMIC's GPIO registers are much different from the GPIO >> registers of the AXP20x and AXP813 PMICs supported by the existing >> pinctrl-axp209 driver. It makes more sense to add a new driver for >> the AXP192, rather than add support in the existing axp20x driver. >> >> The pinctrl-axp192 driver is considerably more flexible in terms of >> register layout and should be able to support other X-Powers PMICs. >> Interrupts and pull down resistor configuration are supported too. >> >> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@xxxxxxxxx> > >Looks good to me (TM) but I'd like Michael Walle to take a look >to check if this is one of those drivers that could make use of >gpio-regmap.c CONFIG_GPIO_REGMAP to make it even >simpler. > >Yours, >Linus Walleij FWIW, I can look at it at the end of next week. I'm on vacation. -michael
