On Sat, 11 Jun 2022 00:59:34 +0800 Jiaqing Zhao wrote: > Currently kernel NCSI driver only supports the "VLAN + non-VLAN" mode > (Mode #2), but this mode is an optional mode [1] defined in NCSI spec > and some NCSI devices like Intel E810 Network Adapter [2] does not > support that mode. This patchset adds a new "ncsi,vlan-mode" device > tree property for configuring the VLAN mode of NCSI device. > > [1] Table 58 - VLAN Enable Modes > https://www.dmtf.org/sites/default/files/standards/documents/DSP0222_1.0.0.pdf > [2] 12.6.5.4.3 VLAN > https://cdrdv2.intel.com/v1/dl/getContent/613875 Please don't post the same patches more than once a day. You posted the same patches 3 times within 15 minutes with no major difference :/ Why is "ncsi,vlan-mode" set via the device tree? Looks like something that can be configured at runtime.