Re: [PATCH v2 01/12] dt-bindings: display/msm: hdmi: split and convert to yaml

[David Heidelberg <david@xxxxxxx>]

On 08/06/2022 14:37, Krzysztof Kozlowski wrote:
> On 08/06/2022 14:07, Dmitry Baryshkov wrote:
> > Convert Qualcomm HDMI binding into HDMI TX and PHY yaml bindings.
> >
> > Changes to schema:
> > HDMI:
> >   - fixed reg-names numbering to match 0..3 instead 0,1,3,4
> >   - dropped qcom,tx-ddc-* from example, they were not documented
> >
> > PHY:
> >   - moved into phy/ directory
> >   - split into QMP and non-QMP PHY schemas
> >
> > Co-developed-by: David Heidelberg <david@xxxxxxx>
> David also needs to SoB here.

no problem, for this or any later version of patches developed by me:

Signed-off-by: David Heidelberg <david@xxxxxxx>

> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > ---
> (...)
>
> > +$id: http://devicetree.org/schemas/display/msm/hdmi.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm Adreno/Snapdragon HDMI output
> > +
> > +maintainers:
> > +  - Rob Clark <robdclark@xxxxxxxxx>
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - qcom,hdmi-tx-8084
> > +      - qcom,hdmi-tx-8660
> > +      - qcom,hdmi-tx-8960
> > +      - qcom,hdmi-tx-8974
> > +      - qcom,hdmi-tx-8994
> > +      - qcom,hdmi-tx-8996
> > +
> > +  clocks:
> > +    minItems: 1
> > +    maxItems: 5
> > +
> > +  clock-names:
> > +    minItems: 1
> > +    maxItems: 5
> > +
> > +  reg:
> > +    minItems: 1
> > +    maxItems: 3
> > +
> > +  reg-names:
> > +    minItems: 1
> > +    items:
> > +      - const: core_physical
> > +      - const: qfprom_physical
> > +      - const: hdcp_physical
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  phys:
> > +    maxItems: 1
> > +
> > +  phy-names:
> > +    enum:
> > +      - hdmi_phy
> > +      - hdmi-phy
> I did not notice your question on v1. I see now two DTS files using two
> different names... yeah, let's mark it deprecated and remove entirely
> from DTS. Let's hope DTS does not have other users than Linux kernel. :)
>
> > +
> > +  core-vdda-supply:
> > +    description: phandle to VDDA supply regulator
> > +
> > +  hdmi-mux-supply:
> > +    description: phandle to mux regulator
> > +
> > +  core-vcc-supply:
> > +    description: phandle to VCC supply regulator
> > +
> (...)
>
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - qcom,hdmi-phy-8660
> > +      - qcom,hdmi-phy-8960
> > +      - qcom,hdmi-phy-8974
> > +      - qcom,hdmi-phy-8084
> > +
> > +  reg:
> > +    maxItems: 2
> > +
> > +  reg-names:
> > +    items:
> > +      - const: hdmi_phy
> > +      - const: hdmi_pll
> > +
> > +  clocks:
> > +    minItems: 1
> > +    maxItems: 2
> > +
> > +  clock-names:
> > +    minItems: 1
> > +    maxItems: 2
> > +
> > +  power-domains:
> > +    maxItems: 1
> > +
> > +  core-vdda-supply:
> > +    description: phandle to VDDA supply regulator
> Blank line
>
> > +  vddio-supply:
> > +    description: phandle to VDD I/O supply regulator
> > +
>
> Best regards,
> Krzysztof

--
David Heidelberg
Consultant Software Engineer

Matrix: @okias:matrix.org

Attachment: OpenPGP_0x60023FC4D3492072.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature