On Sun, 5 Jun 2022 18:05:01 +0200, Krzysztof Kozlowski wrote: > The DTS uses hardware register values directly in pin controller pin > configuration. These are not some IDs or other abstraction layer but > raw numbers used in the registers. > > These numbers were previously put in the bindings header to avoid code > duplication and to provide some context meaning (name), but they do not > fit the purpose of bindings. It is also quite confusing to use > constants prefixed with Exynos for other SoC, because there is actually > nothing here in common, except the actual value. > > [...] Applied, thanks! [1/8] ARM: dts: s3c2410: use local header for pinctrl register values https://git.kernel.org/krzk/linux/c/5dba27958273ffc0056795a479550957a134e981 Best regards, -- Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>