On Fri, 03 Jun 2022 11:00:18 +0300, Vladimir Zapolskiy wrote: > The change adds device tree bindings for camera clock controller > found on SM8450 SoC. > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@xxxxxxxxxx> > --- > Changes from v5 to v6: > * added Rob's tag. > > Changes from v4 to v5: > * fixed a typo in a usage example found in the yaml file. > > Changes from v3 to v4: > * renamed a filename in $id value after the rename of the file itself. > > Changes from v2 to v3: > * renamed files to match the compatible value "qcom,sm8450-camcc", > * fixed a typo in a usage example found in the yaml file. > > Changes from v1 to v2: > * updated qcom,camcc-sm8450.yaml according to review comments from Rob, > * changed qcom,camcc-sm8450.h license to dual one. > > .../bindings/clock/qcom,sm8450-camcc.yaml | 89 ++++++++++ > include/dt-bindings/clock/qcom,sm8450-camcc.h | 159 ++++++++++++++++++ > 2 files changed, 248 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml > create mode 100644 include/dt-bindings/clock/qcom,sm8450-camcc.h > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.example.dtb: clock-controller@ade0000: reg: [[0, 182321152], [0, 131072]] is too long From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
