On 02/06/2022 11:34, Krzysztof Kozlowski wrote: > On 02/06/2022 07:32, Chanho Park wrote: >> To support secondary ufs phy devices, we need to get an offset value >> from pmu-syscon. >> >> Signed-off-by: Chanho Park <chanho61.park@xxxxxxxxxxx> >> --- >> .../devicetree/bindings/phy/samsung,ufs-phy.yaml | 13 ++++++++++--- >> 1 file changed, 10 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml >> index f6ed1a005e7a..d0ba92aa578d 100644 >> --- a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml >> +++ b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml >> @@ -40,9 +40,16 @@ properties: >> - const: tx0_symbol_clk >> >> samsung,pmu-syscon: >> - $ref: '/schemas/types.yaml#/definitions/phandle' >> - description: phandle for PMU system controller interface, used to >> - control pmu registers bits for ufs m-phy >> + $ref: '/schemas/types.yaml#/definitions/phandle-array' >> + items: >> + minItems: 1 >> + items: >> + - description: phandle for PMU system controller interface, used to >> + control pmu registers bits for ufs m-phy >> + - description: offset of the pmu control register > > This does not work... Please test your bindings with different cases. Just to be clear - when I mentioned that minItems should be on second items level, I meant it should affect the second items list, not the first. Now you can have 1, 2 or 10 phandles. Best regards, Krzysztof