On Tue, Sep 23, 2014 at 04:01:13PM +0200, Antoine Tenart wrote: > Arnd, > > On Tue, Sep 23, 2014 at 02:38:39PM +0200, Arnd Bergmann wrote: > > On Tuesday 23 September 2014 14:15:30 Antoine Tenart wrote: > > > +Optional properties: > > > +- port-id: should be '0','1' or '2'. > > > +- phy-addr: MDIO address of the PHY. > > > +- local-mac-address: see ethernet.txt file in the same directory. > > > + > > > > > > > I believe new bindings should not use "phy-addr" properties, but > > instead use a phy-handle property pointing to a phy device instead. > So I had a look on other Ethernet bindings. Would you agree with something like the following? eth0: ethernet@f7b90000 { ... #address-cells = <1>; #size-cells = <0>; phy-handle = <ðphy0>; ethphy0: ethernet-phy@0 { reg = <0>; }; }; Antoine -- Antoine Ténart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html