Arnd, On Tue, Sep 23, 2014 at 02:38:39PM +0200, Arnd Bergmann wrote: > On Tuesday 23 September 2014 14:15:30 Antoine Tenart wrote: > > +Optional properties: > > +- port-id: should be '0','1' or '2'. > > +- phy-addr: MDIO address of the PHY. > > +- local-mac-address: see ethernet.txt file in the same directory. > > + > > > > I believe new bindings should not use "phy-addr" properties, but > instead use a phy-handle property pointing to a phy device instead. That's the MDIO address of the PHY. It's a bit difficult to use a phy device as the driver uses the libphy. And that would break the platform using it. Or maybe you have something in mind? > > The port-id property description could be a little more verbose. > What do those numbers actually mean? I'll add some description. That's the Ethernet port number. I reused a property (port-id) already used by other drivers. Antoine -- Antoine Ténart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
