Hi, Matthias: Matthias Brugger <matthias.bgg@xxxxxxxxx> 於 2022年5月13日 週五 下午3:42寫道： > > Hi Chun-Kuang, > > On 02/05/2022 00:54, Chun-Kuang Hu wrote: > > Hi, Matthias: > > > > Matthias Brugger <matthias.bgg@xxxxxxxxx> 於 2022年4月22日 週五 下午8:42寫道： > >> > >> > >> > >> On 19/04/2022 11:41, jason-jh.lin wrote: > >>> After mmsys and drm change DITHER enum to DDP_COMPONENT_DITHER0, > >>> mmsys header can remove the useless DDP_COMPONENT_DITHER enum. > >>> > >>> Signed-off-by: jason-jh.lin <jason-jh.lin@xxxxxxxxxxxx> > >>> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> > >> > >> Acked-by: Matthias Brugger <matthias.bgg@xxxxxxxxx> > >> > >> Chun-Kuang, I think it would make sense to take that through your tree as it > >> depends on the previous patches. > >> > >> I provide you a stable tag so that you can take it: > >> v5.18-next-vdso0-stable-tag > > > > After I take this tag, I find one checkpatch warning: > > > > WARNING: DT compatible string "mediatek,mt8195-mmsys" appears > > un-documented -- check ./Documentation/devicetree/bindings/ > > #670: FILE: drivers/soc/mediatek/mtk-mmsys.c:390: > > + .compatible = "mediatek,mt8195-mmsys", > > > > I think this tag lost one binding patch, it's better that this tag has > > no this warning. > > > > Sorry for the late reply I was sick. > The warning is, because the stable branch misses commit: > https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/commit/?h=v5.18-next/soc&id=81c5a41d10b968ea89d5f44fe1e5c2fc70289209 > > So it's not a real issue and will go away once our branches land in upstream. > Is it OK for you to ignore the issue? It's OK for me, but the patch would go through different maintainer's tree and I'm not sure it's OK for all of them. So I would wait for the necessary patch land in upstream. Regards, Chun-Kuang. > > Regards, > Matthias > > > Regards, > > Chun-Kuang. > > > >> > >> Regards, > >> Matthias > >> > >>> --- > >>> include/linux/soc/mediatek/mtk-mmsys.h | 3 +-- > >>> 1 file changed, 1 insertion(+), 2 deletions(-) > >>> > >>> diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h > >>> index 59117d970daf..fb719fd1281c 100644 > >>> --- a/include/linux/soc/mediatek/mtk-mmsys.h > >>> +++ b/include/linux/soc/mediatek/mtk-mmsys.h > >>> @@ -16,8 +16,7 @@ enum mtk_ddp_comp_id { > >>> DDP_COMPONENT_CCORR, > >>> DDP_COMPONENT_COLOR0, > >>> DDP_COMPONENT_COLOR1, > >>> - DDP_COMPONENT_DITHER, > >>> - DDP_COMPONENT_DITHER0 = DDP_COMPONENT_DITHER, > >>> + DDP_COMPONENT_DITHER0, > >>> DDP_COMPONENT_DITHER1, > >>> DDP_COMPONENT_DP_INTF0, > >>> DDP_COMPONENT_DP_INTF1,
