Hi, On Wed, May 11, 2022 at 6:39 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote: > > @@ -176,6 +189,37 @@ allOf: > - reg > - interrupts > > + - if: > + properties: > + compatible: > + contains: > + const: google,cros-ec-fp > + then: > + properties: > + '#address-cells': false > + '#size-cells': false > + typec: false > + ec-pwm: false > + keyboard-controller: false > + proximity: false > + codecs: false > + cbas: false > + > + patternProperties: > + "^i2c-tunnel[0-9]*$": false > + "^regulator@[0-9]+$": false > + "^extcon[0-9]*$": false > + > + required: > + - reset-gpios > + - boot0-gpios > + - vdd-supply > + else: > + properties: > + reset-gpios: false > + boot0-gpios: false > + vdd-supply: false Wow, that's a huge pain to have to specify it this way, but I don't know of any other way to make things happy and still have the "google,cros-ec-spi" fallback that we decided on having in previous versions. > additionalProperties: false > > examples: > @@ -231,4 +275,22 @@ examples: > compatible = "google,cros-ec-rpmsg"; > }; > }; > + > + - | nit: all the other examples have a little "# For <blah>" comment before them. It's not really necessary, but do we want one here to match? In any case, it seems OK to me. Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
