On 12/05/2022 14:24, Alexandre Bailon wrote: > From: Michael Kao <michael.kao@xxxxxxxxxxxx> > > This patch adds binding document for mt6873 thermal controller. Thank you for your patch. There is something to discuss/improve. > > Signed-off-by: Michael Kao <michael.kao@xxxxxxxxxxxx> > Signed-off-by: Ben Tseng <ben.tseng@xxxxxxxxxxxx> > --- > .../thermal/mediatek-thermal-lvts.yaml | 81 +++++++++++++++++++ > 1 file changed, 81 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml > > diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml b/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml > new file mode 100644 > index 000000000000..69ffe7b14c21 > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml filename: vendor,device so something like mediatek,mt6873-lvts.yaml or mediatek,mt6873-lvts-thermal.yaml > @@ -0,0 +1,81 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/thermal/mediatek-thermal-lvts.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mediatek SoC LVTS thermal controller (DTS) binding s/(DTS) binding// (unless DTS means something related to hardware) > + > +maintainers: > + - Yu-Chia Chang <ethan.chang@xxxxxxxxxxxx> > + - Ben Tseng <ben.tseng@xxxxxxxxxxxx> > + > +properties: > + compatible: > + const: mediatek,mt6873-lvts > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + items: > + - const: lvts_clk Skip "_clk" suffix, so just lvts. > + > + "#thermal-sensor-cells": > + const: 0 > + > +required: > + - "#thermal-sensor-cells" > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names You should reference in allOf therma-sensor.yaml unless this is not a thermal sensor? > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/thermal/thermal.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/clock/mt8192-clk.h> > + dts: lvts@1100b000 { Generic node name, so thermal-sensor > + compatible = "mediatek,mt6873-lvts"; > + reg = <0x1100b000 0x1000>; > + clocks = <&infracfg CLK_INFRA_THERM>; > + clock-names = "lvts_clk"; > + #thermal-sensor-cells = <0>; > + interrupts = <GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>; > + }; > + > + thermal-zones { > + cpu_thermal: cpu-thermal { > + polling-delay-passive = <0>; > + polling-delay = <0>; > + > + thermal-sensors = <&dts>; > + trips { > + cpu_alert1: cpu-alert1 { > + temperature = <85000>; > + hysteresis = <0>; > + type = "passive"; > + }; > + > + cpu_crit: cpu-crit { > + temperature = <120000>; > + hysteresis = <0>; > + type = "critical"; > + }; > + }; > + > + cooling-maps { > + }; Empty node? Is it used anyhow here? > + }; > + }; > +... Best regards, Krzysztof
