On 10/05/2022 05:25, Jacky Huang wrote: > Add documentation to describe Nuvoton MA35D1 clock driver bindings. > > Signed-off-by: Jacky Huang <ychuang3@xxxxxxxxxxx> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/nuvoton,ma35d1-clk.h> > + > + clk: clock-controller@40460200 { > + compatible = "nuvoton,ma35d1-clk"; > + reg = <0x0 0x40460200 0x0 0x100>; I don't think you tested your bindings. This fails. clock-names below as well. Please do not send untested code. Testing is explained here: https://elixir.bootlin.com/linux/v5.18-rc6/source/Documentation/devicetree/bindings/writing-schema.rst#L111 Best regards, Krzysztof