On 11 May 2022 09:10, Primoz Fiser wrote:
> >> Document the watchdog disable option which can be used if the hardware
> >> automatic suspend option is broken.
> >>
> >> Based on commit c514430c51ee8 ("dt-bindings: watchdog: da9062: add
> >> suspend disable option").
> >>
> >> Signed-off-by: Primoz Fiser <primoz.fiser@xxxxxxxxx>
> >> ---
> >> Documentation/devicetree/bindings/mfd/da9063.txt | 9 ++++++---
> >> 1 file changed, 6 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/mfd/da9063.txt
> >> b/Documentation/devicetree/bindings/mfd/da9063.txt
> >> index 91b79a21d403..aa8b800cc4ad 100644
> >> --- a/Documentation/devicetree/bindings/mfd/da9063.txt
> >> +++ b/Documentation/devicetree/bindings/mfd/da9063.txt
> >> @@ -64,10 +64,13 @@ Sub-nodes:
> >> and KEY_SLEEP.
> >>
> >> - watchdog : This node defines settings for the Watchdog timer associated
> >
> > I don't know if this is just me, but it looks like you're deleting this line
> > above, but not replacing it.....
>
> I am not deleting this line, please note the leading white-space.
>
> But yeah, if you don't pay close attention it looks a bit confusing
> indeed :)
There you go. Thought it would be a strange deletion. Ignore me :)
>
> >
> >> - with the DA9063 and DA9063L. There are currently no entries in this
> >> - binding, however compatible = "dlg,da9063-watchdog" should be added
> >> - if a node is created.
> >
> > ....here, if I'm reading this patch correctly. This means we're losing that
> > property description, and starting a text block with the below text.
> >
> >> + with the DA9063 and DA9063L. The node should contain the compatible
> >> property
> >> + with the value "dlg,da9063-watchdog".
> >>
> >> + Optional watchdog properties:
> >> + - dlg,use-sw-pm: Add this property to disable the watchdog during suspend.
> >> + Only use this option if you can't use the watchdog automatic suspend
> >> + function during a suspend (see register CONTROL_B).
> >>
> >> Example:
> >>
> >> --
> >> 2.25.1
> >
>
> Would you like:
>
> The node should contain the compatible property with the value
> compatible = "dlg,da9063-watchdog".
>
> i.e. explicitly adding "compatible =" in front, for v2?
No change necessary. It just looked odd when I thought that first line was being
deleted. Given that's not the case:
Reviewed-by: Adam Thomson <DLG-Adam.Thomson.Opensource@xxxxxxxxxxxxxx>
