Hi Mikhail, csharper2005@xxxxxxxxx wrote on Tue, 10 May 2022 23:07:23 +0300: > Hi Miquel, > > On 3/30/2022 11:09 AM, Miquel Raynal wrote: > > Hi Mikhail, > > > > csharper2005@xxxxxxxxx wrote on Tue, 29 Mar 2022 12:20:16 +0000: > > > >> This adds an MTD partition parser for the Sercomm partition table that > >> is used in some Beeline, Netgear and Sercomm routers. > >> > >> The Sercomm partition map table contains real partition offsets, which > >> may differ from device to device depending on the number and location of > >> bad blocks on NAND. > >> > >> Device tree example: > >> partitions { > >> compatible = "sercomm,sc-partitions", "fixed-partitions"; > >> #address-cells = <1>; > >> #size-cells = <1>; > >> > >> partition@0 { > >> label = "u-boot"; > >> reg = <0x0 0x100000>; > >> scpart-id = <0>; > >> read-only; > >> }; > >> }; > > You'll need a DT binding patch and Rob's ack! > > I hope that I near to finish with DT binding... > > Link: > https://lore.kernel.org/all/20220510162314.20810-1-csharper2005@xxxxxxxxx/ > > Link: > https://lore.kernel.org/all/20220510162403.20861-1-csharper2005@xxxxxxxxx/ > > >> This is essentially the same code as proposed by NOGUCHI Hiroshi > >> <drvlabo@xxxxxxxxx> here: > > I would credit Hiroshi with a Suggested-by at least > > I read submitting patches rules again and thought that Signed-off-by is > suitable for this case. Is this ok? Either you take his work almost like it is and he must be the author *and* the first signed-off-by line, or you take the authorship if you think you did enough modifications to the code and in this case you can either credit him with a suggested-by before your signed-off, or you can credit him with a co-developed-by + his signed-off and then yours. > > Link: > https://lore.kernel.org/all/20220510162655.21011-1-csharper2005@xxxxxxxxx/ > > >> https://github.com/openwrt/openwrt/pull/1318#issuecomment-420607394 > > And use a Link: tag for this. > > > Fixed, thanks! > > Link: > https://lore.kernel.org/all/20220510162655.21011-1-csharper2005@xxxxxxxxx/ > > > Thanks, > > Miquèl Thanks, Miquèl