Hi Sergei,
Thanks for the feedback.
> Subject: Re: [PATCH] arm64: dts: renesas: r9a07g043: Add ADC node
>
> On 5/10/22 11:24 AM, Biju Das wrote:
> [...]
>
> >>> Add ADC node to R9A07G043 (RZ/G2UL) SoC DTSI.
> >>>
> >>> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> >>> ---
> >>> arch/arm64/boot/dts/renesas/r9a07g043.dtsi | 21 ++++++++++++++++++++-
> >>> 1 file changed, 20 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
> >> b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
> >>> index b31fb713ae4d..40201a16d653 100644
> >>> --- a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
> >>> +++ b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
> >>> @@ -483,8 +483,27 @@ i2c3: i2c@10058c00 {
> >>> };
> >>>
> >>> adc: adc@10059000 {
> >>> + compatible = "renesas,r9a07g043-adc", "renesas,rzg2l-
> >> adc";
> >>> reg = <0 0x10059000 0 0x400>;
> >>> - /* place holder */
> >>> + interrupts = <GIC_SPI 347 IRQ_TYPE_EDGE_RISING>;
> >>> + clocks = <&cpg CPG_MOD R9A07G043_ADC_ADCLK>,
> >>> + <&cpg CPG_MOD R9A07G043_ADC_PCLK>;
> >>> + clock-names = "adclk", "pclk";
> >>> + resets = <&cpg R9A07G043_ADC_PRESETN>,
> >>> + <&cpg R9A07G043_ADC_ADRST_N>;
> >>> + reset-names = "presetn", "adrst-n";
> >>
> >> Not "adrst_n"?
> >
> > As per bindings[1], it is correct ie, "adrst-n"
> >
> >
>
> Then I think the bindings aren't actually correct. But nevermind... :-)
Why do you think it is not correct? What difference it make, changing from
adrst-n->adrst_n? Is it violating any DT specification?
Please clarify.
Regards,
Biju
