On Tue, May 10, 2022 at 5:25 AM Jacky Huang <ychuang3@xxxxxxxxxxx> wrote: > > This patch series adds initial support for Nuvoton MA35D1 SoC, > include initial dts and clock controller binding. > This looks fine in principle, but we are getting close to the merge window and should finalize this quickly to make it into v5.19. I see that you don't have a console device, as commented in the .dts patch. Normally I prefer merging platforms only when there is at least rudimentary support for booting into an initramfs with a serial console, but this is a flexible rule. As with the changelog text for the .dts file, please explain in the [PATCH 0/5] cover letter what the status is. Regarding continued maintainership, we should discuss how you plan to maintain this platform. In particular, there should be an entry in the MAINTAINERS file for the platform, either pointing to yourself, or adding it to the NPCM or WPCM450 entries if this chip is in the same family. Is this also a BMC implementation, or is it something different? Arnd