On 03/05/2022 17:03, Frank Wunderlich wrote: > > have not posted this version as it was failing in dtbs_check, this was how i tried: > > https://github.com/frank-w/BPI-R2-4.14/blob/8f2033eb6fcae273580263c3f0b31f0d48821740/Documentation/devicetree/bindings/net/dsa/mediatek.yaml#L177 You have mixed up indentation of the second if (and missing -). (...) >>> >>> basicly this "ports"-property should be required too, right? >> >> Previous binding did not enforce it, I think, but it is reasonable to >> require ports. > > basicly it is required in dsa.yaml, so it will be redundant here > > https://elixir.bootlin.com/linux/v5.18-rc5/source/Documentation/devicetree/bindings/net/dsa/dsa.yaml#L55 > > this defines it as pattern "^(ethernet-)?ports$" and should be processed by dsa-core. so maybe changing it to same pattern instead of moving up as normal property? Just keep what is already used in existing DTS. >>> for 33 there seem no constant..all other references to pio node are with numbers too and there seem no binding >>> header defining the gpio pins (only functions in include/dt-bindings/pinctrl/mt7623-pinfunc.h) >> >> ok, then my comment > > you mean adding a comment to the example that GPIO-flags/constants should be used instead of magic numbers? I think something was cut from my reply. I wanted to say: "ok, then my comment can be skipped" But I think your check was not correct. I looked at bpi-r2 DTS (mt7623n) and pio controller uses GPIO flags. Best regards, Krzysztof
