Hi, On Mon, May 2, 2022 at 9:22 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote: > > @@ -113,3 +135,56 @@ examples: > /* UP LEFT */ > 0x070b0067 0x070c0069>; > }; > + > + - | > + keyboard-controller { > + compatible = "google,cros-ec-keyb-switches", "google,cros-ec-keyb"; > + /* Matrix keymap properties are allowed but ignored */ nit: s/allowed/required/ This now looks reasonable and well explained to me. Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>