On Mon, May 2, 2022 at 10:40 PM <nick.hawkins@xxxxxxx> wrote:
> > +++ b/arch/arm/boot/dts/hpe-bmc-dl360gen10.dts
> In the board specific file, you normally have "aliases", "chosen" and "memory"
> nodes that define e.g. which uart is used for the console.
This is what I have come up with.
/ {
#address-cells = <1>;
#size-cells = <1>;
compatible = "hpe,gxp-dl360gen10", "hpe,gxp";
model = "Hewlett Packard Enterprise ProLiant dl360 Gen10";
aliases {
serial2 = &uartc;
};
chosen {
bootargs = "console=ttyS2,115200";
};
memory@40000000 {
device_type = "memory";
reg = <0x40000000 0x20000000>;
};
};
> > +/dts-v1/;
> > +/ {
> > + model = "Hewlett Packard Enterprise GXP BMC";
> > + compatible = "hpe,gxp", "hpe,gxp-dl360gen10";
> I think "hpe,gxp-dl360gen10" is misplaced here, if that is the identifier of a particular machine rather than the SoC.
Yes that does not look correct there it will now be compatible = "hpe,gxp";
> > + memory@40000000 {
> > + device_type = "memory";
> > + reg = <0x40000000 0x20000000>;
> > + };
> If the memory is outside of the SoC, it should not be here.
It is part of the SoC. Should I put it in the axi bus instead? If so would I need to create an axi for the .dts as well?
Thanks for the review,
-Nick Hawkins
