Hi Rob,
Name the property based on the h/w quirk rather than what to do in
response. Something like 'dlg,hw-suspend-broken'
Shouldn't we match da9062's property?
As this commit is based on c514430c51ee8 ("dt-bindings: watchdog:
da9062: add suspend disable option") which uses "dlg,use-sw-pm" as
property to implement the same functionality.
Sure I can spin up v2 with your proposal but I think that would create
unnecessary ambiguity and confusion?
For example, phyCORE board uses da9062 PMIC while phyFLEX uses da9063 as
PMIC. Boards are from the same SoM vendor. So one board would have to
use "dlg,use-sw-pm" and the other one "dlg,hw-suspend-broken" property
to achieve the same thing?
On 2. 05. 22 22:56, Rob Herring wrote:
On Fri, Apr 22, 2022 at 09:27:11AM +0200, Primoz Fiser wrote:
Document the watchdog disable option which can be used if the hardware
automatic suspend option is broken.
Based on commit c514430c51ee8 ("dt-bindings: watchdog: da9062: add
suspend disable option").
Signed-off-by: Primoz Fiser <primoz.fiser@xxxxxxxxx>
---
Documentation/devicetree/bindings/mfd/da9063.txt | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/da9063.txt b/Documentation/devicetree/bindings/mfd/da9063.txt
index 91b79a21d403..aa8b800cc4ad 100644
--- a/Documentation/devicetree/bindings/mfd/da9063.txt
+++ b/Documentation/devicetree/bindings/mfd/da9063.txt
@@ -64,10 +64,13 @@ Sub-nodes:
and KEY_SLEEP.
- watchdog : This node defines settings for the Watchdog timer associated
- with the DA9063 and DA9063L. There are currently no entries in this
- binding, however compatible = "dlg,da9063-watchdog" should be added
- if a node is created.
+ with the DA9063 and DA9063L. The node should contain the compatible property
+ with the value "dlg,da9063-watchdog".
+ Optional watchdog properties:
+ - dlg,use-sw-pm: Add this property to disable the watchdog during suspend.
Name the property based on the h/w quirk rather than what to do in
response. Something like 'dlg,hw-suspend-broken'
+ Only use this option if you can't use the watchdog automatic suspend
+ function during a suspend (see register CONTROL_B).
Example:
--
2.25.1
