On 27.4.2022 21.12, Arnd Bergmann wrote:
On Wed, Apr 27, 2022 at 6:21 PM Mauri Sandberg <maukka@xxxxxxxxxxxx> wrote:
Convert D-Link DNS-323 to use the device tree and remove associated
mach file.
Signed-off-by: Mauri Sandberg <maukka@xxxxxxxxxxxx>
---
arch/arm/boot/dts/Makefile | 3 +
arch/arm/boot/dts/orion5x-dlink-dns323.dtsi | 217 ++++++
arch/arm/boot/dts/orion5x-dlink-dns323a1.dts | 59 ++
arch/arm/boot/dts/orion5x-dlink-dns323b1.dts | 38 +
arch/arm/boot/dts/orion5x-dlink-dns323c1.dts | 80 ++
arch/arm/mach-orion5x/Kconfig | 6 +-
arch/arm/mach-orion5x/Makefile | 2 +-
arch/arm/mach-orion5x/board-dns323.c | 118 +++
arch/arm/mach-orion5x/board-dt.c | 3 +
arch/arm/mach-orion5x/common.h | 6 +
arch/arm/mach-orion5x/dns323-setup.c | 724 -------------------
11 files changed, 528 insertions(+), 728 deletions(-)
create mode 100644 arch/arm/boot/dts/orion5x-dlink-dns323.dtsi
create mode 100644 arch/arm/boot/dts/orion5x-dlink-dns323a1.dts
create mode 100644 arch/arm/boot/dts/orion5x-dlink-dns323b1.dts
create mode 100644 arch/arm/boot/dts/orion5x-dlink-dns323c1.dts
create mode 100644 arch/arm/mach-orion5x/board-dns323.c
delete mode 100644 arch/arm/mach-orion5x/dns323-setup.c
Having the combined patch is generally fine for review, but for actually
merging it, I would prefer splitting the new DT from the code removal,
as I send these through different trees to Linus.
You know, I had them initially in separate patches but then I looked at
the existing commit history and at least a few ones were in a single
commit so I merged them. :)
Will split this in two in the next iteration.
