Hello all, I am making an attempt to create a device tree for D-Link DNS-323 devices but I am falling short on a few specific details. I am requesting a general review of the device tree files. I have access to DNS-323 rev A1 only and the B1 and C1 need to be tested separately, so I am reaching out to people who might have them. The questions that I have at the moment are below. - some of resulting IRQs are different from what was requested in device tree - logs say NR_IRQS is different from mach file one - sata_mv fails to initialise with -22 (-EINVAL) - there is no concensus on how to get ascii formatted MAC address from mtd partitions so eth is not fully functional without setting the MAC from userspace - revs B1 and C1 need testing - how to configure RTC to wake system from sleep? What currently works in rev A1 - leds - keys - fan - temperature sensor - shutdown - reboot - mtd partitions - ethernet (mac address must be set manually) I have included relevant parts from boot log to better illustrate what seems to be off target -------------------------------- DT log --------------------------------------- ... NR_IRQS: 16, nr_irqs: 16, preallocated irqs: 16 ... sata_mv 0000:00:01.0: Gen-IIE 32 slots 4 ports SCSI mode IRQ via INTx sata_mv: probe of 0000:00:01.0 failed with error -22 ... mv64xxx_i2c mv64xxx_i2c.0: can't get pinctrl, bus recovery not supported ... ------------------------------------------------------------------------------- Best regards, Mauri Mauri Sandberg (1): ARM: orion5x: convert D-Link DNS-323 to the Device Tree arch/arm/boot/dts/Makefile | 3 + arch/arm/boot/dts/orion5x-dlink-dns323.dtsi | 217 ++++++ arch/arm/boot/dts/orion5x-dlink-dns323a1.dts | 59 ++ arch/arm/boot/dts/orion5x-dlink-dns323b1.dts | 38 + arch/arm/boot/dts/orion5x-dlink-dns323c1.dts | 80 ++ arch/arm/mach-orion5x/Kconfig | 6 +- arch/arm/mach-orion5x/Makefile | 2 +- arch/arm/mach-orion5x/board-dns323.c | 118 +++ arch/arm/mach-orion5x/board-dt.c | 3 + arch/arm/mach-orion5x/common.h | 6 + arch/arm/mach-orion5x/dns323-setup.c | 724 ------------------- 11 files changed, 528 insertions(+), 728 deletions(-) create mode 100644 arch/arm/boot/dts/orion5x-dlink-dns323.dtsi create mode 100644 arch/arm/boot/dts/orion5x-dlink-dns323a1.dts create mode 100644 arch/arm/boot/dts/orion5x-dlink-dns323b1.dts create mode 100644 arch/arm/boot/dts/orion5x-dlink-dns323c1.dts create mode 100644 arch/arm/mach-orion5x/board-dns323.c delete mode 100644 arch/arm/mach-orion5x/dns323-setup.c base-commit: 46cf2c613f4b10eb12f749207b0fd2c1bfae3088 -- 2.25.1
