On Wed, Apr 27, 2022 at 6:21 PM Mauri Sandberg <maukka@xxxxxxxxxxxx> wrote: > > Hello all, > > I am making an attempt to create a device tree for D-Link DNS-323 devices > but I am falling short on a few specific details. I am requesting a > general review of the device tree files. I have access to DNS-323 rev A1 > only and the B1 and C1 need to be tested separately, so I am reaching out > to people who might have them. Hi Mauri, It's really nice to see some progress on this! I don't have the hardware, but I'll try to answer some of your questions anyway. > The questions that I have at the moment are below. > > - some of resulting IRQs are different from what was requested in device tree > - logs say NR_IRQS is different from mach file one This is all normal: with a board file, all on-board IRQs are statically assigned to fixed numbers. With DT based boot, IRQ controllers usually define their own IRQ domains, which get a number space assigned according to probe order, and above the preallocated IRQ numbers. > - sata_mv fails to initialise with -22 (-EINVAL) No idea, I'd try inserting a printk in every code path that can return -EINVAL from there > - there is no concensus on how to get ascii formatted MAC address from mtd > partitions so eth is not fully functional without setting the MAC from > userspace Ideally this is handled by the boot loader, but that requires being able to update it. If you cannot, this could perhaps be done using something like https://github.com/zonque/pxa-impedance-matcher Arnd
