On Tue, Apr 26, 2022 at 08:35:43AM +0000, Joel Stanley wrote: > On Mon, 25 Apr 2022 at 07:59, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > > > On 22/04/2022 20:30, Jonathan Neuschäfer wrote: > > > The Nuvoton WPCM450 SoC has a combined clock and reset controller. > > > Add a devicetree binding for it, as well as definitions for the bit > > > numbers used by it. > > > > > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@xxxxxxx> > > > --- [...] > > > +/* Other clocks */ > > > +#define WPCM450_CLK_USBPHY 32 > > > + > > > +#define WPCM450_NUM_CLKS 33 > > > + > > > +/* Resets based on IPSRST bits */ > > > > All these defines should be in second header in dt-bindings/reset/... > > I disagree. It makes more sense to keep the definitions together, and > it's all for the same hardware and driver. It's for the same hardware, DT node, and driver. I could imagine splitting it into include/dt-bindings/clock/nuvoton,wpcm450-clk.h and include/dt-bindings/reset/nuvoton,wpcm450-clk.h if someone insists on it. For convenience (being able to see all relevant definitions for nuvoton,wpcm450-clk at once), I'd prefer to keep the definitions together. Thanks, Jonathan
Attachment:
signature.asc
Description: PGP signature
