On 27/04/2022 18:21, Mauri Sandberg wrote:
> Convert D-Link DNS-323 to use the device tree and remove associated
> mach file.
>
Thank you for your patch. There is something to discuss/improve.
> Signed-off-by: Mauri Sandberg <maukka@xxxxxxxxxxxx>
> ---
> arch/arm/boot/dts/Makefile | 3 +
> arch/arm/boot/dts/orion5x-dlink-dns323.dtsi | 217 ++++++
> arch/arm/boot/dts/orion5x-dlink-dns323a1.dts | 59 ++
> arch/arm/boot/dts/orion5x-dlink-dns323b1.dts | 38 +
> arch/arm/boot/dts/orion5x-dlink-dns323c1.dts | 80 ++
> arch/arm/mach-orion5x/Kconfig | 6 +-
> arch/arm/mach-orion5x/Makefile | 2 +-
> arch/arm/mach-orion5x/board-dns323.c | 118 +++
> arch/arm/mach-orion5x/board-dt.c | 3 +
> arch/arm/mach-orion5x/common.h | 6 +
> arch/arm/mach-orion5x/dns323-setup.c | 724 -------------------
> 11 files changed, 528 insertions(+), 728 deletions(-)
> create mode 100644 arch/arm/boot/dts/orion5x-dlink-dns323.dtsi
> create mode 100644 arch/arm/boot/dts/orion5x-dlink-dns323a1.dts
> create mode 100644 arch/arm/boot/dts/orion5x-dlink-dns323b1.dts
> create mode 100644 arch/arm/boot/dts/orion5x-dlink-dns323c1.dts
> create mode 100644 arch/arm/mach-orion5x/board-dns323.c
> delete mode 100644 arch/arm/mach-orion5x/dns323-setup.c
DTS goes separately.
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 7c16f8a2b738..c7c5c0b6c843 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -949,6 +949,9 @@ dtb-$(CONFIG_SOC_DRA7XX) += \
> dra71-evm.dtb \
> dra76-evm.dtb
> dtb-$(CONFIG_ARCH_ORION5X) += \
> + orion5x-dlink-dns323a1.dtb \
> + orion5x-dlink-dns323b1.dtb \
> + orion5x-dlink-dns323c1.dtb \
> orion5x-kuroboxpro.dtb \
> orion5x-lacie-d2-network.dtb \
> orion5x-lacie-ethernet-disk-mini-v2.dtb \
> diff --git a/arch/arm/boot/dts/orion5x-dlink-dns323.dtsi b/arch/arm/boot/dts/orion5x-dlink-dns323.dtsi
> new file mode 100644
> index 000000000000..2b033d37cbf8
> --- /dev/null
> +++ b/arch/arm/boot/dts/orion5x-dlink-dns323.dtsi
> @@ -0,0 +1,217 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (C) 2022 Mauri Sandberg <maukka@xxxxxxxxxxxx>
> + *
> + */
> +
> +/ {
> + model = "D-Link DNS-323";
> + compatible = "dlink,dns323", "marvell,orion5x";
>
You need to also document the compatibles in bindings file for boards.
It would be nice to convert
Documentation/devicetree/bindings/arm/marvell/marvell,orion5x.txt to DT
Schema (see armada-7k-8k.yaml for example), but it is not a requirement.
Best regards,
Krzysztof
