On Wed, Apr 27, 2022 at 03:49:51PM +0200, Krzysztof Kozlowski wrote: > On 27/04/2022 14:58, Charles Keepax wrote: > > On Wed, Apr 27, 2022 at 12:21:43PM +0000, Charles Keepax wrote: > >> On Wed, Apr 27, 2022 at 08:51:02AM +0200, Krzysztof Kozlowski wrote: > The Arizona schema has unevaluatedProperties: false, which means unknown > properties will not be accepted. Neither Arizona schema nor other > referenced schemas define spi-max-frequency, so when the schema is run, > the property will be unevaluated, thus cause a warning. > > This is visible here at the bottom (with Rob's work-in-progress): > https://lore.kernel.org/linux-devicetree/345716e9-5624-5ba0-09f0-46e9850c546c@xxxxxxxxxx/T/#m4b5d7cfdf34dbd410003b2faae4d840113050c51 > > Although I think that I did not fix it properly, because I missed > 'controller-data', so instead this should be fixed with referencing > spi-peripheral-props like here: > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-5.17.y&id=f412fe11c1a9d815565f3918c56f3fd02167c734 > Ah yes I forgot the unevaluatedProperties didn't work properly, sorry was running things on my DTs here with SPI and they were all passing but of course I don't have Rob's fix to make the unevaluatedProperties actually work. Probably yeah include the spi properties yaml is a better solution as that covers all the properties that might get used. Thanks, Charles