On 27/04/2022 14:58, Charles Keepax wrote: > On Wed, Apr 27, 2022 at 12:21:43PM +0000, Charles Keepax wrote: >> On Wed, Apr 27, 2022 at 08:51:02AM +0200, Krzysztof Kozlowski wrote: >>> The Wolfson Microelectronics Arizona audio can be connected via SPI bus >>> (e.g. WM5110 on Exynos5433 TM2 board), so allow spi-max-frequency >>> property. >>> >>> Reported-by: Rob Herring <robh@xxxxxxxxxx> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >>> --- >> >> Acked-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx> >> > > Apologies but looking at this again I can't quite see why this is > necessary. The Arizona schema should allow properties that arn't > specified. Do you have an example of what failed to warrant this? The Arizona schema has unevaluatedProperties: false, which means unknown properties will not be accepted. Neither Arizona schema nor other referenced schemas define spi-max-frequency, so when the schema is run, the property will be unevaluated, thus cause a warning. This is visible here at the bottom (with Rob's work-in-progress): https://lore.kernel.org/linux-devicetree/345716e9-5624-5ba0-09f0-46e9850c546c@xxxxxxxxxx/T/#m4b5d7cfdf34dbd410003b2faae4d840113050c51 Although I think that I did not fix it properly, because I missed 'controller-data', so instead this should be fixed with referencing spi-peripheral-props like here: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-5.17.y&id=f412fe11c1a9d815565f3918c56f3fd02167c734 Best regards, Krzysztof
