Re: [PATCH v4 2/2] dt-bindings: mailbox: qcom-ipcc: add missing properties into example

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 26, 2022 at 12:18:37PM +0200, David Heidelberg wrote:
> These missing required properties are needed for
> smp2p binding reference checks.
> 
> Also includes cosmetic change to the example formatting.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Signed-off-by: David Heidelberg <david@xxxxxxx>

Reviewed-by: Manivannan Sadhasivam <mani@xxxxxxxxxx>

Thanks,
Mani

> ---
> v3:
>  - add Krzysztof R-b
> ---
>  .../devicetree/bindings/mailbox/qcom-ipcc.yaml        | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
> index c57dd423e98c..50f9aa72c670 100644
> --- a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
> @@ -76,9 +76,14 @@ examples:
>  
>          smp2p-modem {
>                  compatible = "qcom,smp2p";
> -                interrupts-extended = <&ipcc_mproc IPCC_CLIENT_MPSS
> -                                IPCC_MPROC_SIGNAL_SMP2P IRQ_TYPE_EDGE_RISING>;
> -                mboxes = <&ipcc_mproc IPCC_CLIENT_MPSS IPCC_MPROC_SIGNAL_SMP2P>;
> +                qcom,smem = <443>, <429>;
> +                interrupts-extended = <&ipcc IPCC_CLIENT_LPASS
> +                                             IPCC_MPROC_SIGNAL_SMP2P
> +                                             IRQ_TYPE_EDGE_RISING>;
> +                mboxes = <&ipcc IPCC_CLIENT_LPASS
> +                                IPCC_MPROC_SIGNAL_SMP2P>;
>  
> +                qcom,local-pid = <0>;
> +                qcom,remote-pid = <2>;
>                  /* Other SMP2P fields */
>          };
> -- 
> 2.35.1
> 



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux