On 4/26/22 08:54, Frank Wunderlich wrote:
Hi
thanks for fast review.
Gesendet: Dienstag, 26. April 2022 um 17:45 Uhr
Von: "Florian Fainelli" <f.fainelli@xxxxxxxxx>
On 4/26/22 06:49, Frank Wunderlich wrote:
From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
@@ -1190,8 +1191,8 @@ mt7530_port_bridge_join(struct dsa_switch *ds, int port,
struct netlink_ext_ack *extack)
{
struct dsa_port *dp = dsa_to_port(ds, port), *other_dp;
- u32 port_bitmap = BIT(MT7530_CPU_PORT);
struct mt7530_priv *priv = ds->priv;
+ u32 port_bitmap = BIT(priv->cpu_port);
No need to re-order these two lines.
imho it is needed as i now access priv-struct now ;) which is not available at the "old" position
My bad, yes, I was concerned with preserving the reserve christmas tree
style, never mind.
--
Florian
