On Mon, Apr 25, 2022 at 7:14 PM Sean Anderson <sean.anderson@xxxxxxxx> wrote: > The vbus-regulator property was never actually read from the device tree. > Introduce a new property vbus-supply to represent the regulator powering > the VBUS when acting as an A-Device. This supply will be enabled and > disabled as necessary. Note that this is different from vbus-regulator, > which represented the available current available to draw from VBUS in > B-Device mode. Because no one was using vbus-regulator, remove it. > > Signed-off-by: Sean Anderson <sean.anderson@xxxxxxxx> (...) > + vbus-supply: > + description: regulator supplying VBUS. It will be enabled and disabled > + dynamically in OTG mode. I would add a small text snippet like this: "If the regulator is controlled by a GPIO line, this should be modeled as a regulator-fixed and referenced by this supply" - it's helpful because otherwise people tend to start to submit weird stuff like adding yet another GPIO for this. Either way: Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Yours, Linus Walleij
