Hi Shimoda-san, On Wed, Apr 20, 2022 at 8:17 AM Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote: > This patch series adds support Renesas R-Car S4-8 UFS controller. Thanks for your series! > This controller has some restrictions so adds some quirks for it. > Before using this driver, we have to initialize a clock generator > on the environment board (named "Spider") by using the commands of > U-Boot like below: > => i2c dev 0 > => i2c mw 0x6c 0x26 0x05 > => i2c olen 0x6c 2 > => i2c mw 0x6c 0x26c 0x2e You mean we need a driver for the RC21212 clock generator? ;-) Or the boot loader should program the clock generator, like is done on other R-Car boards for e.g. the PCIe clock (BTW, RC21212 also generates the PCIe clock on Spider)? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds