Il 15/04/22 17:36, Fabien Parent ha scritto:
Add node for the MT6359 PMIC keyboard in mt6359.dtsi.
Signed-off-by: Fabien Parent <fparent@xxxxxxxxxxxx>
Hello Fabien,
I agree that all MT6359 PMICs do support pmic-keys, but not all devices using
this PMIC have physical keys connected to that.
Besides, even if all of them did, it wouldn't be guaranteed that key-0 would be
always KEY_POWER, as much as it wouldn't be guaranteed that key-1 would be always
KEY_HOME.
In my opinion, it *is* correct to add mediatek,mt6359-keys to the PMIC dtsi, but
you should do that without declaring any key, hence it's enough to do:
mt6359_keys: mtk-pmic-keys {
compatible = "mediatek,mt6359-keys";
};
... then, any machine that *actually does* have these keys connected and manageable
in Linux should declare its own keys in its own dts/dtsi.
Of course, this means that you'll have to remove your input.h inclusion as well.
Regards,
Angelo
