On Tue, Apr 19, 2022, at 07:31, Christoph Hellwig wrote: > On Fri, Apr 15, 2022 at 04:20:55PM +0200, Sven Peter wrote: >> +++ b/drivers/nvme/host/apple.c >> @@ -0,0 +1,1597 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Apple ANS NVM Express device driver >> + * Copyright The Asahi Linux Contributors > > Is that actually a valid legal entity? > >> +#include <linux/io-64-nonatomic-lo-hi.h> > > Does this controller still not support 64-bit MMIO accesses like > the old Apple PCIe controllers or is this just a leftover? I just checked again and 64-bit accesses seem to work fine. I'll remove the lo_hi_* calls and this include. > > The rest of the code looks fine to me: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thanks! Sven
