On Tue, Apr 19, 2022 at 10:48 AM Andrea Merello <andrea.merello@xxxxxxxxx> wrote: > Il giorno sab 16 apr 2022 alle ore 10:45 Andy Shevchenko > <andy.shevchenko@xxxxxxxxx> ha scritto: > > On Fri, Apr 15, 2022 at 7:40 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > > > On Fri, 15 Apr 2022 15:00:03 +0200 > > > Andrea Merello <andrea.merello@xxxxxxxxx> wrote: ... > > > > +CFLAGS_bno055_ser.o := -I$(src) > > > > > > Via a bit of grepping I can see other instances of this pattern which point out > > > that it's to do with allowing the tracing framework to see trace.h. > > > Perhaps a similar comment here would be good (if nothing else I doubt I'll > > > remember why this magic is here in a few years time!) > > > > Can be done better way, see dwc3 or drivers/base/ trace point implementations. > > May you elaborate, please? It appears that both dwc3 and driver/base > use this same trick of tweaking the CFLAGS in the Makefile in order to > fix the header file thing. What I see is different is that they both > use an (almost empty) trace.c file. Is this what you are suggesting? There are two differences in your code: 1) no separate c module, which... 2) is built depending on CONFIG_TRACE. Hence, no need to have a separate ugly config option. -- With Best Regards, Andy Shevchenko
