Re: [PATCH v1 1/4] dt-bindings: arm: qcom: Document MSM8939 SoC binding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 19/04/2022 03:09, Bryan O'Donoghue wrote:
> Document the MSM8939 and supported boards in upstream Sony "Tulip" M4 Aqua
> and Square APQ8039 T2.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 129cdd246223..0e4f3a4d1a58 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -34,6 +34,7 @@ description: |
>          mdm9615
>          msm8226
>          msm8916
> +	msm8939

Some indentation mixup.

>          msm8974
>          msm8992
>          msm8994
> @@ -133,6 +134,12 @@ properties:
>                - samsung,s3ve3g
>            - const: qcom,msm8226
>  
> +    - items:

The same

> +          - enum:
> +              - square,apq8039-t2
> +              - sony,kanuti-tulip

Please put them in alphabetical order (so sony, square).

> +          - const: qcom,msm8939
> +
>        - items:
>            - enum:
>                - qcom,msm8960-cdp


Best regards,
Krzysztof



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux