On Mon, 18 Apr 2022 at 23:55, Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx> wrote: > > Since a few boards based on QCoM qmp phy use the > 'vdda-max-microamp' & 'vdda-pll-max-microamp' properties to > describe the ufs phy nodes, add them to the dt-bindings doc as well. Ugh. They give a false sense that they are supported. I think in reality they are not used by the kernel. So, ideally, this patch should be accompanied with regulator core change. Or (better) drop them completely. > > This fixes the following '$ make dtbs_check' warning(s): > > sm8350-microsoft-surface-duo2.dt.yaml: phy@1d87000: > 'vdda-max-microamp', 'vdda-pll-max-microamp' do not match any of > the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' > > Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > Cc: Vinod Koul <vkoul@xxxxxxxxxx> > Acked-by: Rob Herring <robh@xxxxxxxxxx> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx> > --- > Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > index c39ead81ecd7..411c79dbfa15 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > @@ -90,6 +90,14 @@ properties: > minItems: 1 > maxItems: 3 > > + vdda-max-microamp: > + description: > + Specifies max. load that can be drawn from phy supply. > + > + vdda-pll-max-microamp: > + description: > + Specifies max. load that can be drawn from pll supply. > + > vdda-phy-supply: > description: > Phandle to a regulator supply to PHY core block. > -- > 2.35.1 > -- With best wishes Dmitry
