On 15/04/2022 20:54, Nishanth Menon wrote: > > I have no idea how this works. There is no documentation for the > compatible, So I am guessing adding it to Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml > is appropriate prior to replacing with "micron,n25q128a11", "jedec,spi-nor"; Compatible is documented in jedec,spi-nor.yaml (through pattern), although it should be followed by "jedec,spi-nor", according to schema. I did not fix that missing compatible fallback, because I did not want to break any setup (I cannot test it), but adding the fallback seems harmless/safe. > > $ git grep micron,n25q128a11 . > arch/arm/boot/dts/imx6qdl-aristainetos.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor"; > arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor"; > arch/arm/boot/dts/keystone-k2e-evm.dts: compatible = "micron,n25q128a11"; > arch/arm/boot/dts/keystone-k2hk-evm.dts: compatible = "micron,n25q128a11"; > arch/arm/boot/dts/keystone-k2l-evm.dts: compatible = "micron,n25q128a11"; > arch/powerpc/boot/dts/fsl/t1024qds.dts: compatible = "micron,n25q128a11", "jedec,spi-nor"; /* 16MB */ > arch/powerpc/boot/dts/fsl/t104xqds.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor"; > arch/powerpc/boot/dts/fsl/t208xqds.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor"; /* 16MB */ > > Best regards, Krzysztof
