Re: [PATCH v3 3/3] MIPS: Ingenic: Refresh USB nodes to match driver changes.

[Paul Cercueil <paul@xxxxxxxxxxxxxxx>]

Hi Zhou,

Le sam., avril 16 2022 at 20:16:33 +0800, Zhou Yanjie 
<zhouyanjie@xxxxxxxxxxxxxx> a écrit :
> Hi Paul,
>
> On 2022/4/15 下午11:07, Paul Cercueil wrote:
> > Hi Zhou,
> >
> >
> > Le ven., avril 15 2022 at 03:25:37 +0800, 周琰杰 (Zhou Yanjie) 
> > <zhouyanjie@xxxxxxxxxxxxxx> a écrit :
> > > Refresh USB nodes in the jz4780.dtsi, x1000.dtsi, and x1830.dtsi 
> > > files.
> > >
> > > Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@xxxxxxxxxxxxxx>
> > > ---
> > >
> > > Notes:
> > >     v3:
> > >     New patch.
> > >
> > >  arch/mips/boot/dts/ingenic/jz4780.dtsi | 2 +-
> > >  arch/mips/boot/dts/ingenic/x1000.dtsi  | 2 +-
> > >  arch/mips/boot/dts/ingenic/x1830.dtsi  | 2 +-
> > >  3 files changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi 
> > > b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> > > index b998301..c182a65 100644
> > > --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
> > > +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> > > @@ -577,7 +577,7 @@
> > >      };
> > >
> > >      otg: usb@13500000 {
> > > -        compatible = "ingenic,jz4780-otg", "snps,dwc2";
> > > +        compatible = "ingenic,jz4780-otg";
> >
> > Could you refresh my memory - why are the "snps,dwc2" fallback 
> > strings removed?
> >
> > To me it seems like they should be here, since the OTG IP in Ingenic 
> > SoCs is derived from the DWC2 IP.
>
>
> The reason is that Nikolaus found that the current jz4780.dtsi will 
> cause
> dtbscheck to complain. After discussion, Nikolaus concluded three 
> feasible
> solutions, see here:
> https://lkml.org/lkml/2022/4/13/1097
>
> And it seems that Krzysztof prefers the c) option.

Understood.

-Paul

> Thanks and best regards!
>
>
> > Cheers,
> > -Paul
> >
> > >          reg = <0x13500000 0x40000>;
> > >
> > >          interrupt-parent = <&intc>;
> > > diff --git a/arch/mips/boot/dts/ingenic/x1000.dtsi 
> > > b/arch/mips/boot/dts/ingenic/x1000.dtsi
> > > index 8bd27ede..343818a2 100644
> > > --- a/arch/mips/boot/dts/ingenic/x1000.dtsi
> > > +++ b/arch/mips/boot/dts/ingenic/x1000.dtsi
> > > @@ -366,7 +366,7 @@
> > >      };
> > >
> > >      otg: usb@13500000 {
> > > -        compatible = "ingenic,x1000-otg", "snps,dwc2";
> > > +        compatible = "ingenic,x1000-otg";
> > >          reg = <0x13500000 0x40000>;
> > >
> > >          interrupt-parent = <&intc>;
> > > diff --git a/arch/mips/boot/dts/ingenic/x1830.dtsi 
> > > b/arch/mips/boot/dts/ingenic/x1830.dtsi
> > > index 2595df8..6aff19f 100644
> > > --- a/arch/mips/boot/dts/ingenic/x1830.dtsi
> > > +++ b/arch/mips/boot/dts/ingenic/x1830.dtsi
> > > @@ -355,7 +355,7 @@
> > >      };
> > >
> > >      otg: usb@13500000 {
> > > -        compatible = "ingenic,x1830-otg", "snps,dwc2";
> > > +        compatible = "ingenic,x1830-otg";
> > >          reg = <0x13500000 0x40000>;
> > >
> > >          interrupt-parent = <&intc>;
> > > --
> > > 2.7.4