> ... > > > >>>> + out: > > >>> > > >>> out_unlock: ? > > >>> Ditto for similar cases. > > >> > > >> There's a single label in the function, and there's a mutex being > > >> taken, and, logically, the mutex must be released on the exit path. > > >> It's clear what the label is for to me. > > > > > > Wasn't clear to me until I went to the end of each of them (who > > > guarantees that's the case for all of them?). > > > > Let's hope other people looking at that code will be able to figure out > > what that label does then. > > OK. Let the maintainer decide. Slight preference for giving the extra info of out_unlock, but not critical. (note I haven't read the code yet so might change my mind :)
