RE: [PATCH 4/7] scsi: ufs-renesas: Add support for Renesas R-Car UFS controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Krzysztof,

Thank you for your review!

> From: Krzysztof Kozlowski, Sent: Tuesday, April 12, 2022 9:25 PM
> 
> On 12/04/2022 09:36, Yoshihiro Shimoda wrote:
> > Add support for Renesas R-Car UFS controller which needs vender specific
> > initialization.
> 
> Thank you for your patch. There is something to discuss/improve.
> 
> > +static const struct of_device_id ufs_renesas_of_match[] = {
> > +	{ .compatible = "renesas,r8a779f0-ufs" },
> > +};
> > +MODULE_DEVICE_TABLE(of, ufs_renesas_of_match);
> > +
> > +static int ufs_renesas_probe(struct platform_device *pdev)
> > +{
> > +	return ufshcd_pltfrm_init(pdev, &ufs_renesas_vops);
> > +}
> > +
> > +static int ufs_renesas_remove(struct platform_device *pdev)
> > +{
> > +	struct ufs_hba *hba = platform_get_drvdata(pdev);
> > +
> > +	ufshcd_remove(hba);
> > +
> > +	return 0;
> > +}
> > +
> > +static struct platform_driver ufs_renesas_platform = {
> > +	.probe	= ufs_renesas_probe,
> > +	.remove	= ufs_renesas_remove,
> > +	.driver	= {
> > +		.name	= "ufshcd-renesas",
> > +		.of_match_table	= of_match_ptr(ufs_renesas_of_match),
> 
> You probably need "__maybe_unused" if you want to keep of_match_ptr.
> Compile test with W=1 on other platforms should point it out. Other
> solution is to remove of_match_ptr().

I'll add __maybe_unused.

Best regards,
Yoshihiro Shimoda





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux