On Thu 07 Apr 12:21 CDT 2022, Jonathan Marek wrote: > Upstream sm8450.dtsi has #interconnect-cells = <2>; so these are wrong. > Ignored and undocumented with upstream UFS driver so delete for now. > Just to clarify, the binding do document interconnects and the property should be there in the end. v1 (why isn't this marked v2?) was correct. What I asked for was a statement on why it should be picked up for v5.18-rc (as Dmitry requested). Regards, Bjorn > Fixes: aa2d0bf04a3c ("arm64: dts: qcom: sm8450: add interconnect nodes") > Signed-off-by: Jonathan Marek <jonathan@xxxxxxxx> > --- > arch/arm64/boot/dts/qcom/sm8450.dtsi | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi > index 2c18e1ef9e82d..90cdbec3cac99 100644 > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi > @@ -1663,9 +1663,6 @@ ufs_mem_hc: ufshc@1d84000 { > > iommus = <&apps_smmu 0xe0 0x0>; > > - interconnects = <&aggre1_noc MASTER_UFS_MEM &mc_virt SLAVE_EBI1>, > - <&gem_noc MASTER_APPSS_PROC &config_noc SLAVE_UFS_MEM_CFG>; > - interconnect-names = "ufs-ddr", "cpu-ufs"; > clock-names = > "core_clk", > "bus_aggr_clk", > -- > 2.26.1 >