Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on driver-core/driver-core-testing] [also build test ERROR on rafael-pm/linux-next robh/for-next linus/master v5.18-rc1 next-20220408] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/device-property-Allow-error-pointer-to-be-passed-to-fwnode-APIs/20220409-025056 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git 3123109284176b1532874591f7c81f3837bbdc17 config: hexagon-randconfig-r041-20220408 (https://download.01.org/0day-ci/archive/20220409/202204091049.rHkbqiFm-lkp@xxxxxxxxx/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project c29a51b3a257908aebc01cd7c4655665db317d66) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/477683439b5ee0954b08970d8c356b4cdaca8bc0 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Andy-Shevchenko/device-property-Allow-error-pointer-to-be-passed-to-fwnode-APIs/20220409-025056 git checkout 477683439b5ee0954b08970d8c356b4cdaca8bc0 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/base/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): >> drivers/base/property.c:782:10: error: returning 'const struct fwnode_handle *' from a function with result type 'struct fwnode_handle *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers] return fwnode; ^~~~~~ 1 error generated. vim +782 drivers/base/property.c 613e97218ccbd7 Adam Thomson 2016-06-21 772 e7887c284969a2 Sakari Ailus 2017-03-28 773 /** e7887c284969a2 Sakari Ailus 2017-03-28 774 * fwnode_handle_get - Obtain a reference to a device node e7887c284969a2 Sakari Ailus 2017-03-28 775 * @fwnode: Pointer to the device node to obtain the reference to. cf89a31ca55272 Sakari Ailus 2017-09-19 776 * cf89a31ca55272 Sakari Ailus 2017-09-19 777 * Returns the fwnode handle. e7887c284969a2 Sakari Ailus 2017-03-28 778 */ 477683439b5ee0 Andy Shevchenko 2022-04-08 779 struct fwnode_handle *fwnode_handle_get(const struct fwnode_handle *fwnode) e7887c284969a2 Sakari Ailus 2017-03-28 780 { cf89a31ca55272 Sakari Ailus 2017-09-19 781 if (!fwnode_has_op(fwnode, get)) cf89a31ca55272 Sakari Ailus 2017-09-19 @782 return fwnode; cf89a31ca55272 Sakari Ailus 2017-09-19 783 cf89a31ca55272 Sakari Ailus 2017-09-19 784 return fwnode_call_ptr_op(fwnode, get); e7887c284969a2 Sakari Ailus 2017-03-28 785 } e7887c284969a2 Sakari Ailus 2017-03-28 786 EXPORT_SYMBOL_GPL(fwnode_handle_get); e7887c284969a2 Sakari Ailus 2017-03-28 787 -- 0-DAY CI Kernel Test Service https://01.org/lkp
