Hi Russell, > -----Original Message----- > From: Russell King [mailto:linux@xxxxxxxxxxxxxxx] > Sent: 2022年3月31日 3:12 PM > To: Dylan Hung <dylan_hung@xxxxxxxxxxxxxx> > Cc: robh+dt@xxxxxxxxxx; joel@xxxxxxxxx; andrew@xxxxxxxx; andrew@xxxxxxx; > hkallweit1@xxxxxxxxx; davem@xxxxxxxxxxxxx; kuba@xxxxxxxxxx; > pabeni@xxxxxxxxxx; p.zabel@xxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-aspeed@xxxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; BMC-SW > <BMC-SW@xxxxxxxxxxxxxx> > Subject: Re: [PATCH v3 2/3] net: mdio: add reset control for Aspeed MDIO > > Hi, > > On Fri, Mar 25, 2022 at 12:14:50PM +0800, Dylan Hung wrote: > > Add reset assertion/deassertion for Aspeed MDIO. There are 4 MDIO > > controllers embedded in Aspeed AST2600 SOC and share one reset control > > register SCU50[3]. To work with old DT blobs which don't have the > > reset property, devm_reset_control_get_optional_shared is used in this > change. > > > > Signed-off-by: Dylan Hung <dylan_hung@xxxxxxxxxxxxxx> > > Reviewed-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> > > Should this really be specific to one driver rather than being handled in the > core mdio code? > Is the core mdio code able to know the reset is shared or exclusive? I supposed that the reset property is hardware dependent. Did I get that right? > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
