On 4/5/2022 7:47 PM, Mark Brown wrote:
On Tue, Apr 05, 2022 at 07:20:31PM +0530, Satya Priya wrote:
+#include <linux/regulator/driver.h>
+#include <linux/regulator/machine.h>
Why does the driver need machine.h? That's usually a bug, though I
didn't spot anywhere where it's used so it's probably just an extra
header.
Yeah, I'll remove it. Thanks for spotting this.
+ .set_voltage_sel = pm8008_regulator_set_voltage,
+ .get_voltage = pm8008_regulator_get_voltage,
You shouldn't mix and match the selector and non-selector operations,
since the device just takes a voltage you may as well just use the
non-selector version for both.
I was suggested to use set_voltage_sel on my previous posts. I think
I'll use get_voltage_sel to avoid mixing selector and non-selector APIs.
Otherwise this all looks good, just those two minor points.
