On 05/04/2022 16:04, Chris Morgan wrote: >>> The driver itself is named rk817_charger. If you think I should change >>> this from battery to "fuel gauge" or "charger" let me know and I can >>> resubmit. Whatever makes it clearer for everyone. >> >> Yeah, the property name and bindings should describe the hardware, so in >> such case the hardware is rather a "charger" or "fuel-gauge". Your >> "battery-cell" from DTS is probably just a "battery" (unless you expect >> multiple cells?). >> >> Best regards, >> Krzysztof > > Okay, when v6 comes around I'll change it to be "charger" instead of > "battery" to make it more clear. There should only be a single battery > instead of multiple cells, and according to the documentation I should > be okay with describing the battery in the devicetree since it's not > something easy for the end-user to change. Yes,the description of battery fits the purpose of DT. > > I'd like to get someone to look at the meat and potatoes of the series > before I submit a v6... I did a fairly substantial rewrite of the > actual rk817_charger.c to solve for several problems and fix several > bugs I found in extended testing. One of the major changes was to > mirror the BSP in that I poll the PMIC every 8 seconds for updates > and then store it in the driver struct rather than pull each value > on demand as requested. I see other drivers doing this but I want > to make sure that's acceptable upstream. Best regards, Krzysztof
